Change in ...osmo-ggsn[master]: gtp: Log msg retransmits and timeouts

pespin gerrit-no-reply at lists.osmocom.org
Thu Aug 29 09:32:19 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15305 )

Change subject: gtp: Log msg retransmits and timeouts
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15305/1/gtp/gtp.c 
File gtp/gtp.c:

https://gerrit.osmocom.org/#/c/15305/1/gtp/gtp.c@604 
PS1, Line 604: 			     qmsg->seq);
> (line width of 120?) […]
That's because "uint16_t" happens to be an "unsigned int" in this architecture/system, but that may not be necessarily the same in other architectures/systems. I prefer using PRIu16 there, it more clearly indicates it's a uint16_t and not an unsigned int.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15305
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie768ddb45313582b4b5358b97a981080be64fd42
Gerrit-Change-Number: 15305
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Aug 2019 09:32:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/095eb84e/attachment.html>


More information about the gerrit-log mailing list