Change in ...osmo-ttcn3-hacks[master]: sgsn: Proper shutdown of RAN_Adapter components

laforge gerrit-no-reply at lists.osmocom.org
Thu Aug 29 05:34:11 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15295 )

Change subject: sgsn: Proper shutdown of RAN_Adapter components
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/15295/2/library/RAN_Adapter.ttcnpp 
File library/RAN_Adapter.ttcnpp:

https://gerrit.osmocom.org/#/c/15295/2/library/RAN_Adapter.ttcnpp@196 
PS2, Line 196: ba.vc_RAN_started
one could probably simply test for "ba.vc_RAN != null" here.  Or you could actually check for "if ba.vc_RAN:RANAP.checkstate("Connected")" like we do in other places.  I don't think there's a need for inroduction of ba.vc_RAN_started, neither is it elegant to add a variable and thus keep redundant state information which may be out of sync if somebody else might already have disconnected the port or stopped a component, or...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15295
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I471eb851e5d41de5d8d974ec81be27024d7d313a
Gerrit-Change-Number: 15295
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Aug 2019 05:34:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/ff302b17/attachment.html>


More information about the gerrit-log mailing list