Change in ...osmo-sip-connector[master]: mncc: do not unregister unregistered osmo fds

neels gerrit-no-reply at lists.osmocom.org
Thu Aug 29 03:55:26 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303 )

Change subject: mncc: do not unregister unregistered osmo fds
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

plz explain...

https://gerrit.osmocom.org/#/c/15303/2/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/15303/2/src/mncc.c@329 
PS2, Line 329: 	close(conn->fd.fd);
I'm also wondering. Have you seen a scenario where an unregistered fd was unregistered again? Would that mean that close_connection() was called twice and this function should exit if the fd is not registered?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I9742f31a37296fed15d54cf44c1f65b93abb8c8e
Gerrit-Change-Number: 15303
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Aug 2019 03:55:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/e9f3af3a/attachment.html>


More information about the gerrit-log mailing list