Change in ...osmo-ggsn[master]: ggsn: Implement echo req/resp and recovery

osmith gerrit-no-reply at lists.osmocom.org
Wed Aug 28 07:08:09 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 )

Change subject: ggsn: Implement echo req/resp and recovery
......................................................................


Patch Set 4:

(10 comments)

https://gerrit.osmocom.org/#/c/15267/4//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15267/4//COMMIT_MSG@10 
PS4, Line 10: differntiated
differ_e_ntiated


https://gerrit.osmocom.org/#/c/15267/4//COMMIT_MSG@19 
PS4, Line 19: o
to


https://gerrit.osmocom.org/#/c/15267/4/ggsn/ggsn.h 
File ggsn/ggsn.h:

https://gerrit.osmocom.org/#/c/15267/4/ggsn/ggsn.h@96 
PS4, Line 96: 	//struct ggsn_ctx *ggsn; can be reached through pdp->gsn->priv
* isn't it lib->gsn->priv?
* AFAIK we are only using /* ... */ style comments


https://gerrit.osmocom.org/#/c/15267/4/ggsn/ggsn.c 
File ggsn/ggsn.c:

https://gerrit.osmocom.org/#/c/15267/4/ggsn/ggsn.c@766 
PS4, Line 766: * 
" *"


https://gerrit.osmocom.org/#/c/15267/4/ggsn/ggsn.c@789 
PS4, Line 789: r*
(missing space)


https://gerrit.osmocom.org/#/c/15267/4/ggsn/ggsn.c@796 
PS4, Line 796: struct gsn_t* gsn
struct gsn_t *gsn


https://gerrit.osmocom.org/#/c/15267/4/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/#/c/15267/4/ggsn/ggsn_vty.c@372 
PS4, Line 372: inteval
interval


https://gerrit.osmocom.org/#/c/15267/4/ggsn/ggsn_vty.c@798 
PS4, Line 798: 			vty_out(vty, " no echo-interval%s", VTY_NEWLINE);
This is the default, so why print the "no echo-interval" line?


https://gerrit.osmocom.org/#/c/15267/4/ggsn/sgsn.h 
File ggsn/sgsn.h:

https://gerrit.osmocom.org/#/c/15267/4/ggsn/sgsn.h@34 
PS4, Line 34: * 
" *"


https://gerrit.osmocom.org/#/c/15267/4/ggsn/sgsn.c 
File ggsn/sgsn.c:

https://gerrit.osmocom.org/#/c/15267/4/ggsn/sgsn.c@9 
PS4, Line 9: idnication
indication



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15267
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Id2c84165dc59dff495106758146a701ca488834f
Gerrit-Change-Number: 15267
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Aug 2019 07:08:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190828/03c5b10f/attachment.html>


More information about the gerrit-log mailing list