Change in ...osmo-ggsn[master]: ggsn_vty.c: Improve output of VTY show pdp-context

osmith gerrit-no-reply at lists.osmocom.org
Wed Aug 28 06:26:54 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15256 )

Change subject: ggsn_vty.c: Improve output of VTY show pdp-context
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/15256/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15256/2//COMMIT_MSG@8 
PS2, Line 8: 
I'd describe here what changed in the output.


https://gerrit.osmocom.org/#/c/15256/2/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/#/c/15256/2/ggsn/ggsn_vty.c@762 
PS2, Line 762: 		if (!pdp->secondary) {
(consider writing the non-inverted condition first)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15256
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: If9682fe343e9a1e78175a12538fb80d4bda54802
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Aug 2019 06:26:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190828/db246606/attachment.html>


More information about the gerrit-log mailing list