Change in ...osmo-msc[master]: smpp_openbsc.c: check acl before deref it

laforge gerrit-no-reply at lists.osmocom.org
Tue Aug 27 12:11:08 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15285 )

Change subject: smpp_openbsc.c: check acl before deref it
......................................................................

smpp_openbsc.c: check acl before deref it

All other calls check acl before deref because in a setup
with no access policy, there won't be any acl structure

Change-Id: Ibe0256535b40351594d79baa05a0147a9f89dc26
---
M src/libmsc/smpp_openbsc.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/src/libmsc/smpp_openbsc.c b/src/libmsc/smpp_openbsc.c
index bbfc500..e4c3891 100644
--- a/src/libmsc/smpp_openbsc.c
+++ b/src/libmsc/smpp_openbsc.c
@@ -326,7 +326,7 @@
 				"ESME is not (yet) bound, skipping alert\n");
 			continue;
 		}
-		if (!esme->acl->alert_notifications) {
+		if (esme->acl && !esme->acl->alert_notifications) {
 			LOGP(DSMPP, LOGL_DEBUG,
 				"[%s] is not set to receive Alert Notifications\n",
 					esme->system_id);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15285
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ibe0256535b40351594d79baa05a0147a9f89dc26
Gerrit-Change-Number: 15285
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190827/037554a7/attachment.html>


More information about the gerrit-log mailing list