Change in ...osmo-trx[master]: Transceiver: Check return value when binding IP addr for clock socket

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 26 18:50:58 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15287 )

Change subject: Transceiver: Check return value when binding IP addr for clock socket
......................................................................

Transceiver: Check return value when binding IP addr for clock socket

No need to continue further since anyway we'll end up exiting.

Change-Id: Id8b38b40df5744beb705d560defb06532cf0fd44
---
M Transceiver52M/Transceiver.cpp
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index e946aac..244f372 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -212,6 +212,8 @@
 				    mLocalAddr.c_str(), mBasePort,
 				    mRemoteAddr.c_str(), mBasePort + 100,
 				    OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT);
+  if (mClockSocket < 0)
+    return false;
 
   for (size_t i = 0; i < mChans; i++) {
     c_srcport = mBasePort + 2 * i + 1;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15287
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Id8b38b40df5744beb705d560defb06532cf0fd44
Gerrit-Change-Number: 15287
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190826/9a728009/attachment.html>


More information about the gerrit-log mailing list