Change in ...osmo-trx[master]: Transceiver: Enable EDGE detection only on PDCH timeslots

fixeria gerrit-no-reply at lists.osmocom.org
Mon Aug 26 14:56:42 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15291 )

Change subject: Transceiver: Enable EDGE detection only on PDCH timeslots
......................................................................


Patch Set 1:

(1 comment)

Looks fine, but I am afraid it breaks EDGE burst detection on combined channel combinations.

https://gerrit.osmocom.org/#/c/15291/1/Transceiver52M/Transceiver.cpp 
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/#/c/15291/1/Transceiver52M/Transceiver.cpp@557 
PS1, Line 557: ((mod52 == 12) || (mod52 == 38))
Unrelated: glad to see that at least here RACH detection on PTCCH/U is implemented correctly.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15291
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Id16248a1c03f9bc9f323c707857cdf3bf34c4e3e
Gerrit-Change-Number: 15291
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 26 Aug 2019 14:56:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190826/39b13230/attachment.html>


More information about the gerrit-log mailing list