This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15289 ) Change subject: Transceiver: exit process when BTS drops connection ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/15289/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/15289/1/Transceiver52M/Transceiver.cpp@711 PS1, Line 711: true > If I understand correctly, any IDLE frame or clipping would stop the process? No, true means success and false means failure everywhere. https://gerrit.osmocom.org/#/c/15289/1/Transceiver52M/Transceiver.cpp@772 PS1, Line 772: false > Same here, not sure if we should stop the process if an incorrect message was received. I hesitated here (I first had it as true), but after thinking about it, if we receive something non CMD, it definetly makes sense to drop the connection because probably something unrelated is connecting here to this socket. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2ccbe3c17b39fb792ea7810f840235c348054d66 Gerrit-Change-Number: 15289 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 26 Aug 2019 12:26:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190826/36398032/attachment.htm>