This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15288 ) Change subject: Transceiver: Clean up receival of downlink bursts ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/Transceiver.cpp@932 PS2, Line 932: EDGE_BURST_NBITS + 50 > This size could be also corrected as a part of this change. Agree. Not sure where the 50 come from though, probably just a "big-enough" value. https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/proto_trxd.h File Transceiver52M/proto_trxd.h: https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/proto_trxd.h@72 PS2, Line 72: rssi > This is not RSSI. Either call it 'tx_att' (Tx Attenuation), or 'pwr'. The variable it was assigned to in the code was called RSSI. That's why it's good to have these structs :D -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4d8c0e3c0c717699889f79e50c778d14b6058f2d Gerrit-Change-Number: 15288 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2019 12:23:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190826/b209edbe/attachment.htm>