Change in ...osmo-trx[master]: Transceiver: Clean up receival of downlink bursts

fixeria gerrit-no-reply at lists.osmocom.org
Mon Aug 26 10:29:45 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15288 )

Change subject: Transceiver: Clean up receival of downlink bursts
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/Transceiver.cpp 
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/Transceiver.cpp@932 
PS2, Line 932: EDGE_BURST_NBITS + 50
This size could be also corrected as a part of this change.


https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/Transceiver.cpp@944 
PS2, Line 944: trxd_hdr_v01_dl
Cosmetic (feel free to keep as is): sizeof(*dl).


https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/proto_trxd.h 
File Transceiver52M/proto_trxd.h:

https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/proto_trxd.h@72 
PS2, Line 72: rssi
This is not RSSI. Either call it 'tx_att' (Tx Attenuation), or 'pwr'.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15288
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I4d8c0e3c0c717699889f79e50c778d14b6058f2d
Gerrit-Change-Number: 15288
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Aug 2019 10:29:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190826/cee58986/attachment.html>


More information about the gerrit-log mailing list