Change in ...osmo-pcu[master]: gprs_bssgp_destroy(): fix NULL-pointer dereference

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 23 17:07:48 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15281 )

Change subject: gprs_bssgp_destroy(): fix NULL-pointer dereference
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/15281/1/src/gprs_bssgp_pcu.cpp 
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/#/c/15281/1/src/gprs_bssgp_pcu.cpp@980 
PS1, Line 980: #warning "This causes ASAN to complain. It is not critical for normal operation but should be fixed nevertheless"
Would be great to check with git log if this warning is related to same thing (bctx being NULL).
You are missing putting everything inside the same block:


if (the_pcu.bctx != NULL) {
  llist_del(&the_pcu.bctx->list);
  #warning "..."
#if 0
  talloc_free(the_pcu.bctx);
#endif 
  the_pcu.bctx = NULL;
}



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15281
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I42cb911a679b9198fd06e74b42f1e2cb28323de9
Gerrit-Change-Number: 15281
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Aug 2019 17:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190823/b8c46781/attachment.html>


More information about the gerrit-log mailing list