Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): further simplify the code

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 23 17:04:29 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15280 )

Change subject: osmobts_sock.cpp: pcu_sock_read(): further simplify the code
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15280/1/src/osmobts_sock.cpp 
File src/osmobts_sock.cpp:

https://gerrit.osmocom.org/#/c/15280/1/src/osmobts_sock.cpp@146 
PS1, Line 146: 	if (rc <= 0) {
This looks a lot simpler:

if (rc < 0 && errno == EAGAIN)
    return 0;
if (rc <= 0) {
    pcu_sock_close(state, 1);
    return -EIO;
}



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15280
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie7c0ca8baf0ae5beadda60bda0bc76a44664d439
Gerrit-Change-Number: 15280
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Aug 2019 17:04:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190823/9cff666c/attachment.html>


More information about the gerrit-log mailing list