Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 23 16:08:07 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15278 )

Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15278/2/src/osmobts_sock.cpp 
File src/osmobts_sock.cpp:

https://gerrit.osmocom.org/#/c/15278/2/src/osmobts_sock.cpp@265 
PS2, Line 265: 	state->conn_bfd.cb = pcu_sock_cb;
I think these 2 lines should be set before calling osmo_sock_unix_init_ofd()? Or is it fine this way?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9
Gerrit-Change-Number: 15278
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Aug 2019 16:08:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190823/a97d983a/attachment.html>


More information about the gerrit-log mailing list