Change in ...osmo-bsc[master]: abis_nm.c: use LOGP() macro instead of LOGPC()

fixeria gerrit-no-reply at lists.osmocom.org
Fri Aug 23 15:49:30 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15277 )

Change subject: abis_nm.c: use LOGP() macro instead of LOGPC()
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c 
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c@314 
PS1, Line 314: 	LOGPC(DNM, LOGL_ERROR, "BTS %u: Failure Event Report: ", bts->nr);
> The ones here look like they need fixing too.
Done.


https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c@344 
PS1, Line 344: 			LOGP(DNM, LOGL_NOTICE, "BTS %u reported connected PCU version %s\n", bts->nr, text);
> Don't we have LOGBTS or something similar? Or even better, pass foh as parameter and use LOGPFOH.
This is an idea for a separate change. Unfortunately there is no such macro. And... do we really need to know more than the BTS number?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15277
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563
Gerrit-Change-Number: 15277
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Aug 2019 15:49:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190823/9f1e10f1/attachment.html>


More information about the gerrit-log mailing list