Change in ...osmo-ggsn[master]: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 23 13:20:27 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15259 )

Change subject: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15259/1/ggsn/ggsn.c 
File ggsn/ggsn.c:

https://gerrit.osmocom.org/#/c/15259/1/ggsn/ggsn.c@389 
PS1, Line 389: 	if (apn && apn->cfg.gtpu_mode == APN_GTPU_MODE_KERNEL_GTP) {
> Why is this in the same patch? It seems like an unrelated fix.
It's not unrelated. Since now we free pdp contexts being rejected, it means they were never assigned an APN so apn is going to be NULL. I'm sure it happens, I had to fix it after I wrote the patch ;)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15259
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I6c6215a4ce478afabc78ffaf5ffb0cf829e41226
Gerrit-Change-Number: 15259
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Aug 2019 13:20:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190823/69c4a5c5/attachment.html>


More information about the gerrit-log mailing list