Change in ...osmo-iuh[master]: hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw

laforge gerrit-no-reply at lists.osmocom.org
Fri Aug 23 06:42:04 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15268 )

Change subject: hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw
......................................................................

hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw

Otherwise the process hangs if the user enters:

  $ show hnb NAME

hnbgw_vty.c: In function ‘show_one_hnb’:
hnbgw_vty.c:234:2: warning: passing argument 1 of
                   ‘hnb_context_by_identity_info’
		   from incompatible pointer type
		   [enabled by default]
iuh/hnbgw.h:154:21: note: expected ‘struct hnb_gw *’
                    but argument is of type ‘struct hnb_gw **’

Change-Id: I42fdb10af5f6427886b5797325830dfc212af30f
---
M src/hnbgw_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/hnbgw_vty.c b/src/hnbgw_vty.c
index 15fdaf8..84a5f01 100644
--- a/src/hnbgw_vty.c
+++ b/src/hnbgw_vty.c
@@ -231,7 +231,7 @@
 		return CMD_SUCCESS;
 	}
 
-	hnb = hnb_context_by_identity_info(&g_hnb_gw, identity_info);
+	hnb = hnb_context_by_identity_info(g_hnb_gw, identity_info);
 	if (hnb == NULL) {
 		vty_out(vty, "No HNB found with identity '%s'%s", identity_info, VTY_NEWLINE);
 		return CMD_SUCCESS;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15268
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I42fdb10af5f6427886b5797325830dfc212af30f
Gerrit-Change-Number: 15268
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190823/5638cd49/attachment.html>


More information about the gerrit-log mailing list