Change in ...osmo-ggsn[master]: ggsn: Implement echo req/resp and recovery

pespin gerrit-no-reply at lists.osmocom.org
Thu Aug 22 16:08:25 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 )

Change subject: ggsn: Implement echo req/resp and recovery
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

This change is ready for review.

https://gerrit.osmocom.org/#/c/15267/1/ggsn/ggsn.c 
File ggsn/ggsn.c:

https://gerrit.osmocom.org/#/c/15267/1/ggsn/ggsn.c@350 
PS1, Line 350: 	struct apn_ctx *apn = pdp_priv->apn;
Self-note: This line needs to be: 
struct apn_ctx *apn;


https://gerrit.osmocom.org/#/c/15267/1/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/#/c/15267/1/ggsn/ggsn_vty.c@360 
PS1, Line 360: 	"echo-interval <0-36000>",
TODO: update VTY .xml file.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15267
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Id2c84165dc59dff495106758146a701ca488834f
Gerrit-Change-Number: 15267
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Aug 2019 16:08:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190822/b2af0ba6/attachment.html>


More information about the gerrit-log mailing list