Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always run verbose asciidoc

osmith gerrit-no-reply at lists.osmocom.org
Wed Aug 21 11:24:50 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15030 )

Change subject: Makefile.asciidoc.inc: always run verbose asciidoc
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15030/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15030/1//COMMIT_MSG@15 
PS1, Line 15: This prevents losing the error message in case asciidoc or a2x fail
> I don't really understand what you mean in the paragraph.
While analyzing OS#4131 (leveloffset attribute warning), I saw once in the logs that asciidoc running with a2x failed. But we were not running a2x with -vv, so there was no error message. Then the Makefile ran asciidoc as standalone to find the error, and then it did not fail anymore.

Another example that I experienced at some point is, that a2x may fail for a reason unrelated to asciidoc. Then we run asciidoc as standalone and it reports that everything went okay. This is confusing and makes it harder to find the actual error message.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15030
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I2cbd2985645ecdecc7851849be6a9a95d4b3246e
Gerrit-Change-Number: 15030
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Aug 2019 11:24:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190821/ec3bbf52/attachment.html>


More information about the gerrit-log mailing list