Change in ...osmo-sgsn[master]: Replace own timer infra with libosmocore osmo_tdef

osmith gerrit-no-reply at lists.osmocom.org
Tue Aug 20 10:48:58 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 )

Change subject: Replace own timer infra with libosmocore osmo_tdef
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/15214/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15214/2//COMMIT_MSG@8 
PS2, Line 8: 
How about mentioning the new VTY commands here?


https://gerrit.osmocom.org/#/c/15214/2/src/gprs/gprs_gmm.c 
File src/gprs/gprs_gmm.c:

https://gerrit.osmocom.org/#/c/15214/2/src/gprs/gprs_gmm.c@2287 
PS2, Line 2287: 
empty line at start of function


https://gerrit.osmocom.org/#/c/15214/2/src/gprs/gprs_gmm.c@2291 
PS2, Line 2291: 
unrelated change



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15214
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia0cf5f0a49737fbc419e2ccc86312d01c6e0056e
Gerrit-Change-Number: 15214
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2019 10:48:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190820/343efaae/attachment.html>


More information about the gerrit-log mailing list