Change in ...osmo-ttcn3-hacks[master]: Revert "RAN_Adapter: invert check for RAN_ops == omit"

osmith gerrit-no-reply at lists.osmocom.org
Mon Aug 19 11:44:58 UTC 2019


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15233


Change subject: Revert "RAN_Adapter: invert check for RAN_ops == omit"
......................................................................

Revert "RAN_Adapter: invert check for RAN_ops == omit"

This reverts commit 5932cd3463d04c45404c538daff6d25bc3f3d002. It caused
a lot of tests in the ttcn3-bsc-test, ttcn3-bsc-test-latest and
ttcn3-bsc-test-sccplite-latest testsuites to fail with:

RAN_Adapter.ttcnpp:179 Dynamic test case error: Text encoder: Encoding an unbound optional value.

Related: OS#4156
Change-Id: I441c701553eef8e9e018d11923359eb3f3b26826
---
M library/RAN_Adapter.ttcnpp
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/15233/1

diff --git a/library/RAN_Adapter.ttcnpp b/library/RAN_Adapter.ttcnpp
index 8e19241..e995e8d 100644
--- a/library/RAN_Adapter.ttcnpp
+++ b/library/RAN_Adapter.ttcnpp
@@ -90,7 +90,7 @@
 
 	/* create components */
 	ba.vc_SCCP := SCCP_CT.create(id & "-SCCP");
-	if (not istemplatekind(ops, "omit")) {
+	if (isvalue(ops)) {
 		ba.vc_RAN := RAN_Emulation_CT.create(id & "-RAN");
 	}
 	select (cfg.transport) {
@@ -142,7 +142,7 @@
 		}
 	}
 
-	if (not istemplatekind(ops, "omit")) {
+	if (isvalue(ops)) {
 		timer T := 5.0;
 		T.start;
 		//T.timeout;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15233
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I441c701553eef8e9e018d11923359eb3f3b26826
Gerrit-Change-Number: 15233
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190819/3cad3468/attachment.html>


More information about the gerrit-log mailing list