Change in ...osmo-ttcn3-hacks[master]: MSC_Tests: do not send an SGsAP-MO-CSFB-INDICATION when testing MT-Call

laforge gerrit-no-reply at lists.osmocom.org
Sun Aug 18 17:13:21 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15220 )

Change subject: MSC_Tests: do not send an SGsAP-MO-CSFB-INDICATION when testing MT-Call
......................................................................

MSC_Tests: do not send an SGsAP-MO-CSFB-INDICATION when testing MT-Call

The TTCN3 tests MSC_Tests.TC_bssap_lu_sgsap_lu_and_mt_call and
MSC_Tests.TC_sgsap_lu_and_mt_call initate an MT-CSFB call for testing
purposes, but they also send an SGsAP-MO-CSFB-INDICATION to make the MS
come back to LTE. This is wrong. SGsAP-MO-CSFB-INDICATION just informs
the VLR that the UE has initiated a MO CSFB call on the LTE side. On MT
CSFB calls this message should not appear. Lets remove it.

Related: SYS#4624
Change-Id: I2e9fda4fe97866c4cbc77224ba1930ca81411fd6
---
M msc/MSC_Tests.ttcn
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index c463dd5..7499456 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -4980,9 +4980,6 @@
 	/* Make sure that subscriber is still present and the SGs association is in tact (ref-counting) */
 	f_ctrl_get_exp(IPA_CTRL, "fsm.SGs-UE.id.imsi:" & hex2str(g_pars.imsi) & ".state", "SGs-ASSOCIATED");
 
-	/* Finally simulate the return of the UE to the 4G network */
-	SGsAP.send(ts_SGsAP_MO_CSFB_IND(pars.imsi));
-
 	/* Test for successful return by triggering a paging, when the paging
 	 * request is received via SGs, we can be sure that the MSC/VLR has
 	 * recognized that the UE is now back on 4G */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15220
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2e9fda4fe97866c4cbc77224ba1930ca81411fd6
Gerrit-Change-Number: 15220
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190818/81b40779/attachment.html>


More information about the gerrit-log mailing list