Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: invert check for RAN_ops == omit

laforge gerrit-no-reply at lists.osmocom.org
Sun Aug 18 17:12:49 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157 )

Change subject: RAN_Adapter: invert check for RAN_ops == omit
......................................................................

RAN_Adapter: invert check for RAN_ops == omit

The SGSN_Tests.ttcn run into bugs when doing the isvalue() check on a const object.
Check explicit for "omit" to skip creation of the vc_RAN object

Change-Id: I639ab6d0586174c0f20b93a53169f0aa254970fa
---
M library/RAN_Adapter.ttcnpp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/RAN_Adapter.ttcnpp b/library/RAN_Adapter.ttcnpp
index e995e8d..8e19241 100644
--- a/library/RAN_Adapter.ttcnpp
+++ b/library/RAN_Adapter.ttcnpp
@@ -90,7 +90,7 @@
 
 	/* create components */
 	ba.vc_SCCP := SCCP_CT.create(id & "-SCCP");
-	if (isvalue(ops)) {
+	if (not istemplatekind(ops, "omit")) {
 		ba.vc_RAN := RAN_Emulation_CT.create(id & "-RAN");
 	}
 	select (cfg.transport) {
@@ -142,7 +142,7 @@
 		}
 	}
 
-	if (isvalue(ops)) {
+	if (not istemplatekind(ops, "omit")) {
 		timer T := 5.0;
 		T.start;
 		//T.timeout;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I639ab6d0586174c0f20b93a53169f0aa254970fa
Gerrit-Change-Number: 15157
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190818/b30c9169/attachment.html>


More information about the gerrit-log mailing list