Change in ...osmo-ggsn[master]: libgtp: Remove packets in tx queue belonging pdp being freed

pespin gerrit-no-reply at lists.osmocom.org
Sat Aug 17 14:20:15 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15228 )

Change subject: libgtp: Remove packets in tx queue belonging pdp being freed
......................................................................


Patch Set 4:

libgtp already depends on libosmocore
* It's already in osmo-ggsn.git's configure.ac as a PKG_CHECK_MODULES, so it depends on it at compile time.
* only known users to us (osmo-ggsn, osmo-sgsn, sgsnemu?) already depend on libosmocore both compile time and runtime.
* libgtp uses OSMO_DEPRECATED(), wich means again libosmocore is needed at compile time.
* libgtp uses OSMO_ASSERT(), so again needed at compile time.
* libgtp uses osmo_bcd2char(), so it requires libosmocore at runtime
* in Makefile.am, libgtp already links against libosmocore: "libgtp_la_LIBADD = $(LIBOSMOCORE_LIBS)"

So i'm in favour of actually moving libgtp to be more "osmocom" rather than trying to keep it away from it.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15228
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Id86d0b241454d3ad49c64c28087fd2710fa2d17a
Gerrit-Change-Number: 15228
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Sat, 17 Aug 2019 14:20:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190817/a1832755/attachment.html>


More information about the gerrit-log mailing list