Change in ...osmo-iuh[master]: iu_client: introduce a connection state

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 16 10:24:54 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15181 )

Change subject: iu_client: introduce a connection state
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/#/c/15181/5/src/iu_client.c 
File src/iu_client.c:

https://gerrit.osmocom.org/#/c/15181/5/src/iu_client.c@119 
PS5, Line 119: 	ctx->conn_state = RANAP_CONN_STATE_CONNECTED;
How can it be connected here? because there's already a conn_id assigned which is expected to be an open connection?


https://gerrit.osmocom.org/#/c/15181/5/src/iu_client.c@792 
PS5, Line 792: 		/* indication of new inbound connection request*/
Shouldn't _alloc be DISCONNECTED and then in here set it to RANAP_CONN_STATE_CONNECTED?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15181
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I77e01724be05ac488a4685ba367b7a71985b54e3
Gerrit-Change-Number: 15181
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Aug 2019 10:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190816/1d4104c8/attachment.htm>


More information about the gerrit-log mailing list