Change in ...osmo-msc[master]: sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return

dexter gerrit-no-reply at lists.osmocom.org
Fri Aug 16 08:59:06 UTC 2019


dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15221 )

Change subject: sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return
......................................................................

sgs_iface: do not use SGsAP-MO-CSFB-INDICATION for CSFB return

When the VLR/MSC receives an SGsAP-MO-CSFB-INDICATION message it sets
the RAN type back to SGs. This is wrong, the message
SGsAP-MO-CSFB-INDICATION has just an informative character. It informs
the VLR that the UE has initiated an MO CSFB call (service request).

Change-Id: I625574fc42fc915ba483db3bb406922ad6df370d
Related: SYS#4624
---
M src/libmsc/sgs_iface.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index 53ab853..b12991c 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -886,9 +886,10 @@
 {
 	struct vlr_subscr *vsub;
 
-	/* The MME informs us with this message that the UE has returned back
-	 * to the 4G network, so we use the SGs interface again for further
-	 * communication with the UE. */
+	/* The MME informs us with this message that the UE has initiated a
+	 * service request for MO CS fallback. There is not much we can do with
+	 * this information, however, we can check if the subscriber actually
+	 * exists in the VLR and if there are any lingering connections open.*/
 
 	vsub = vlr_subscr_find_by_imsi(gsm_network->vlr, imsi, __func__);
 	if (!vsub)
@@ -897,7 +898,6 @@
 	/* Check for lingering connections */
 	subscr_conn_toss(vsub);
 
-	vsub->cs.attached_via_ran = OSMO_RAT_EUTRAN_SGS;
 	vlr_subscr_put(vsub, __func__);
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15221
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I625574fc42fc915ba483db3bb406922ad6df370d
Gerrit-Change-Number: 15221
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190816/0816f033/attachment.html>


More information about the gerrit-log mailing list