Change in ...osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

laforge gerrit-no-reply at lists.osmocom.org
Thu Aug 15 09:47:31 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 )

Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/#/c/13929/5/src/gprs/sgsn_libgtp.c 
File src/gprs/sgsn_libgtp.c:

https://gerrit.osmocom.org/#/c/13929/5/src/gprs/sgsn_libgtp.c@543 
PS5, Line 543: 	struct sgsn_pdp_ctx *pctx = cbp;
> I wish I knew why there's a pdp_t *and* a separate sgsn_pdp_ctx
because the 'pdp_t' represents a libgtp library data structure and the sgsn_pdp_ctx is the data structure of the application. You cannot expect the library to contain all the application-layer context or vice-versa...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/13929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def
Gerrit-Change-Number: 13929
Gerrit-PatchSet: 5
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Aug 2019 09:47:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190815/04bf666a/attachment.html>


More information about the gerrit-log mailing list