Change in ...libosmocore[master]: osmo_tdef_get(): allow passing -1 as default timeout

fixeria gerrit-no-reply at lists.osmocom.org
Thu Aug 15 07:00:08 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15218 )

Change subject: osmo_tdef_get(): allow passing -1 as default timeout
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/15218/2/src/tdef.c 
File src/tdef.c:

https://gerrit.osmocom.org/#/c/15218/2/src/tdef.c@186 
PS2, Line 186: osmo_tdef_get
Alternatively, you could add another function without that optional parameter, so it would simply crash the process if (t == NULL), while this function would always return the val_if_not_present. Just an idea. The current approach also looks good.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15218
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie61c3c85069916336e6dbd91a2c16f7634816417
Gerrit-Change-Number: 15218
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 07:00:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190815/a69dcbb6/attachment.html>


More information about the gerrit-log mailing list