Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

neels gerrit-no-reply at lists.osmocom.org
Thu Aug 15 00:40:02 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 )

Change subject: Implement a global switch on the network to disable call waiting.
......................................................................


Patch Set 12: Code-Review+1

(2 comments)

non-mandatory stuff...

https://gerrit.osmocom.org/#/c/15120/12/src/libmsc/msc_vty.c 
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/15120/12/src/libmsc/msc_vty.c@309 
PS12, Line 309:       "Disable Call Waiting on the Network\n")
(could follow up with a longer description like "...: while a call is active, reject all other incoming calls")


https://gerrit.osmocom.org/#/c/15120/12/tests/test_nodes.vty 
File tests/test_nodes.vty:

https://gerrit.osmocom.org/#/c/15120/12/tests/test_nodes.vty@30 
PS12, Line 30: 
it would also be nice to add tests that ensure the write-back works:

  OsmoMSC(config-net)# show running-config
  ...
   call-waiting
  ...
  OsmoMSC(config-net)# no call-waiting
  OsmoMSC(config-net)# show running-config
  ...
   no call-waiting
  ...
  OsmoMSC(config-net)# call-waiting
  OsmoMSC(config-net)# show running-config
  ...
   call-waiting
  ...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae
Gerrit-Change-Number: 15120
Gerrit-PatchSet: 12
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 15 Aug 2019 00:40:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190815/58a2598e/attachment.html>


More information about the gerrit-log mailing list