Change in ...osmo-sgsn[master]: tests: Check timers can be set over VTY

neels gerrit-no-reply at lists.osmocom.org
Thu Aug 15 00:20:11 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15213 )

Change subject: tests: Check timers can be set over VTY
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15213/1/tests/vty_test_runner.py 
File tests/vty_test_runner.py:

https://gerrit.osmocom.org/#/c/15213/1/tests/vty_test_runner.py@277 
PS1, Line 277:             self.assertTrue(self.vty.verify('timer t%d 10' % t, ['']))
> I would encourage to instead add vty transcript tests. They are far easier to maintain... […]
Oh wait, you actually did add transcript tests in a later patch! :D



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15213
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I486fc2a56e235a539836894d2042c1ca6e514ab9
Gerrit-Change-Number: 15213
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Aug 2019 00:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190815/3494edec/attachment.html>


More information about the gerrit-log mailing list