This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15213 ) Change subject: tests: Check timers can be set over VTY ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/15213/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15213/1//COMMIT_MSG@7 PS1, Line 7: tests: Check timers can be set over VTY you mean "add tests to verify that...", right? (I didn't understand when I read it) https://gerrit.osmocom.org/#/c/15213/1/tests/vty_test_runner.py File tests/vty_test_runner.py: https://gerrit.osmocom.org/#/c/15213/1/tests/vty_test_runner.py@277 PS1, Line 277: self.assertTrue(self.vty.verify('timer t%d 10' % t, [''])) I would encourage to instead add vty transcript tests. They are far easier to maintain... You can easily copy-paste the Makefile.am bits from osmo-msc and add a timers.vty file. Or maybe next time. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I486fc2a56e235a539836894d2042c1ca6e514ab9 Gerrit-Change-Number: 15213 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Thu, 15 Aug 2019 00:00:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190815/d9df2b2c/attachment.htm>