Change in ...osmo-sgsn[master]: gprs_gmm: Introduce assert to guard against unexpected condition

neels gerrit-no-reply at lists.osmocom.org
Wed Aug 14 23:20:25 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15167 )

Change subject: gprs_gmm: Introduce assert to guard against unexpected condition
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/15167/2/src/gprs/gprs_gmm.c 
File src/gprs/gprs_gmm.c:

https://gerrit.osmocom.org/#/c/15167/2/src/gprs/gprs_gmm.c@1747 
PS2, Line 1747: mmctx->ran_type == MM_CTX_T_GERAN_Gb
> Oh, sorry, I was confused. Can we simplify the code a bit? […]
I'm also confused.
The condition matching the current patch would have to be

  if (mmctx->ran_type == MM_CTX_T_GERAN_Gb)
    OSMO_ASSERT(mmctx->gb.llme);

But it makes no sense when reading the comment above it.
To make sure of no dangling pointers I also expected an 'gb.llme = NULL' assignment instead of an assert?

Pau, can you explain better what the intention is and possibly fix the condition?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15167
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I8e1eaeb9b3ebee8e45704b4fe007190c7db609e4
Gerrit-Change-Number: 15167
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 14 Aug 2019 23:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190814/221772ab/attachment.html>


More information about the gerrit-log mailing list