Change in ...osmo-sgsn[master]: gprs_gmm: Avoid spaces in fsm events and enum strings

pespin gerrit-no-reply at lists.osmocom.org
Wed Aug 14 14:57:56 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15212


Change subject: gprs_gmm: Avoid spaces in fsm events and enum strings
......................................................................

gprs_gmm: Avoid spaces in fsm events and enum strings

FSM doesn't expect receiving event names containing spaces (log lines
generated are confusing).

Similar for enums, it's better using code names to match easily and make
log lines more clear.

Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1
---
M src/gprs/gprs_gmm.c
M src/gprs/gprs_gmm_attach.c
2 files changed, 16 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/12/15212/1

diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index 9ab09c4..5d03923 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -107,12 +107,12 @@
 };
 
 static const struct value_string gprs_pmm_state_names[] = {
-	{ PMM_DETACHED,		"PMM DETACH" },
-	{ PMM_CONNECTED,	"PMM CONNECTED" },
-	{ PMM_IDLE,		"PMM IDLE" },
-	{ MM_IDLE,		"MM IDLE" },
-	{ MM_READY,		"MM READY" },
-	{ MM_STANDBY,		"MM STANDBY" },
+	{ PMM_DETACHED,		"PMM_DETACH" },
+	{ PMM_CONNECTED,	"PMM_CONNECTED" },
+	{ PMM_IDLE,		"PMM_IDLE" },
+	{ MM_IDLE,		"MM_IDLE" },
+	{ MM_READY,		"MM_READY" },
+	{ MM_STANDBY,		"MM_STANDBY" },
 	{ 0, NULL }
 };
 
diff --git a/src/gprs/gprs_gmm_attach.c b/src/gprs/gprs_gmm_attach.c
index 1ab11f7..84a2cf5 100644
--- a/src/gprs/gprs_gmm_attach.c
+++ b/src/gprs/gprs_gmm_attach.c
@@ -316,16 +316,16 @@
 };
 
 const struct value_string gmm_attach_req_fsm_event_names[] = {
-	{ E_ATTACH_REQ_RECV,		"Received an attach request" },
-	{ E_IDEN_RESP_RECV,		"Identity Request received" },
-	{ E_AUTH_RESP_RECV_SUCCESS,	"Authentication Response received" },
-	{ E_AUTH_RESP_RECV_RESYNC,	"Authentication Failure with resync received" },
-	{ E_ATTACH_ACCEPTED,		"Attach accepted" },
-	{ E_ATTACH_ACCEPT_SENT,		"Attach accept sent" },
-	{ E_ATTACH_COMPLETE_RECV, 	"Attach complete received." },
-	{ E_IU_SECURITY_CMD_COMPLETE,   "IU Security Command Complete received." },
-	{ E_REJECT,			"Reject the MS"},
-	{ E_VLR_ANSWERED,		"VLR answered"},
+	{ E_ATTACH_REQ_RECV,		"ATTACH_REQ_RECV" },
+	{ E_IDEN_RESP_RECV,		"IDEN_RESP_RECV" },
+	{ E_AUTH_RESP_RECV_SUCCESS,	"AUTH_RESP_RECV_SUCCESS" },
+	{ E_AUTH_RESP_RECV_RESYNC,	"AUTH_RESP_RECV_RESYNC" },
+	{ E_ATTACH_ACCEPTED,		"ATTACH_ACCEPTED" },
+	{ E_ATTACH_ACCEPT_SENT,		"ATTACH_ACCEPT_SENT" },
+	{ E_ATTACH_COMPLETE_RECV, 	"ATTACH_COMPLETE_RECV" },
+	{ E_IU_SECURITY_CMD_COMPLETE,   "IU_SECURITY_CMD_COMPLETE" },
+	{ E_REJECT,			"REJECT"},
+	{ E_VLR_ANSWERED,		"VLR_ANSWERED"},
 	{ 0,				NULL }
 };
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15212
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1
Gerrit-Change-Number: 15212
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190814/86d049e1/attachment.html>


More information about the gerrit-log mailing list