Change in ...osmo-ttcn3-hacks[master]: library: S1AP encoding/decoding using libfftranscode and ASN.1 from V...

laforge gerrit-no-reply at lists.osmocom.org
Wed Aug 14 11:52:07 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15194 )

Change subject: library: S1AP encoding/decoding using libfftranscode and ASN.1 from V15.5.0
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15194/1/library/s1ap/S1AP_CommonDataTypes.asn 
File library/s1ap/S1AP_CommonDataTypes.asn:

https://gerrit.osmocom.org/#/c/15194/1/library/s1ap/S1AP_CommonDataTypes.asn@10 
PS1, Line 10: itu-t (0) identified-organization (4) etsi (0) mobileDomain (0) 
> whitespace
those files are copied verbatim from wiresshark [who hopefully hve it from some official 3GPP source], introducing whitespace changes here is just going to lead to  clashes further down the road if we ever want to update anything.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15194
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie019bef1f3ef9cc5f6c94a64c7f352c510fb5633
Gerrit-Change-Number: 15194
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Aug 2019 11:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190814/65213706/attachment.html>


More information about the gerrit-log mailing list