Change in ...osmo-mgw[master]: test_mgcp_codec_pt_translate(): more tests

neels gerrit-no-reply at lists.osmocom.org
Tue Aug 13 22:21:56 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15135 )

Change subject: test_mgcp_codec_pt_translate(): more tests
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/15135/3/tests/mgcp/mgcp_test.c 
File tests/mgcp/mgcp_test.c:

https://gerrit.osmocom.org/#/c/15135/3/tests/mgcp/mgcp_test.c@1795 
PS3, Line 1795: 		.descr = "both sides have the same payload_type numbers assigned to conflicting codecs",
> Are they really conflicting? This looks misleading, since it's actually fine, right?
with conflicting I mean the same number means something different on the other side.
The test verifies that even those get translated properly.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15135
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I334a075ac2800ae4a7c4e2d6eaeb17dd8c6b09a1
Gerrit-Change-Number: 15135
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Aug 2019 22:21:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/1b6ac865/attachment.html>


More information about the gerrit-log mailing list