Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set

neels gerrit-no-reply at lists.osmocom.org
Tue Aug 13 22:09:56 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 )

Change subject: avoid bogus error logs when no cmd_timer is set
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/15142/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15142/1//COMMIT_MSG@9 
PS1, Line 9: mncc.c often calls stop_cmd_timer() even if no timer is running. If no timer is
> I can't say I've seen this "often". […]
"often": I thought I saw it every time I end a call...? not positively sure since recently I always ran with this patch. But I did see it repeatedly before patching.

There are various places calling the stop_cmd_timer() function. Each one of those invocations would have to become

  if (...timer->active)
      stop_cmd_timer();

thus it makes more sense to me to check for that once, inside the function.


https://gerrit.osmocom.org/#/c/15142/1/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/15142/1/src/mncc.c@74 
PS1, Line 74: 	if (!osmo_timer_pending(&leg->cmd_timeout))
> As far as I can make out, we only start timers immediately before sending an MNCC command to which w […]
I got this:

http://people.osmocom.org/neels/izap8No0/osmo-sip-connector.log.txt

so it seems that the REL_CNF stopped the timer as a "stop it in case it is running" measure. those should IMHO not cause error logs if none was running.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I70f85a71df55ab8618ed78864cefb6fe5b26f581
Gerrit-Change-Number: 15142
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Tue, 13 Aug 2019 22:09:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/ea742807/attachment.html>


More information about the gerrit-log mailing list