Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set
gerrit-no-reply at lists.osmocom.org
Tue Aug 13 22:09:56 UTC 2019
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 )
Change subject: avoid bogus error logs when no cmd_timer is set
Patch Set 1:
PS1, Line 9: mncc.c often calls stop_cmd_timer() even if no timer is running. If no timer is
> I can't say I've seen this "often". […]
"often": I thought I saw it every time I end a call...? not positively sure since recently I always ran with this patch. But I did see it repeatedly before patching.
There are various places calling the stop_cmd_timer() function. Each one of those invocations would have to become
thus it makes more sense to me to check for that once, inside the function.
PS1, Line 74: if (!osmo_timer_pending(&leg->cmd_timeout))
> As far as I can make out, we only start timers immediately before sending an MNCC command to which w […]
I got this:
so it seems that the REL_CNF stopped the timer as a "stop it in case it is running" measure. those should IMHO not cause error logs if none was running.
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Tue, 13 Aug 2019 22:09:56 +0000
Comment-In-Reply-To: keith <keith at rhizomatica.org>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log