Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 13 16:51:19 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 )

Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15161/2/src/iu_client.c 
File src/iu_client.c:

https://gerrit.osmocom.org/#/c/15161/2/src/iu_client.c@153 
PS2, Line 153: 		llist_del(&iter->list);
> if I do this, the llist would crash or i've to use the _safe() list
Not really, afaiu it's fine because you are breaking after deleting it.

And btw, I'm pretty sure you can check if you need to call llist_del without iterating the whole list (by checking pointers or whatever).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b
Gerrit-Change-Number: 15161
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Aug 2019 16:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/8e4d3c7b/attachment.html>


More information about the gerrit-log mailing list