Change in ...osmo-iuh[master]: iu_client: define RANAP_IU_EVENT_SECURITY_MODE_FAILED

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 13 16:41:05 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15177 )

Change subject: iu_client: define RANAP_IU_EVENT_SECURITY_MODE_FAILED
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15177/1/include/osmocom/ranap/iu_client.h 
File include/osmocom/ranap/iu_client.h:

https://gerrit.osmocom.org/#/c/15177/1/include/osmocom/ranap/iu_client.h@38 
PS1, Line 38: 	RANAP_IU_EVENT_SECURITY_MODE_FAILED, /* FIXME: unimplemented */
Why do you define it if you don't use it?
That's breaking ABI compatibility, better put it at the end.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15177
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I14bb9904728eddf7a5742df8382fb204ccda20dd
Gerrit-Change-Number: 15177
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Aug 2019 16:41:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/e7ea0e0e/attachment.html>


More information about the gerrit-log mailing list