Change in ...osmo-sgsn[master]: gprs_gmm: refactor msgid2mmctx() out of switch/case

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Aug 13 11:41:55 UTC 2019


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15174


Change subject: gprs_gmm: refactor msgid2mmctx() out of switch/case
......................................................................

gprs_gmm: refactor msgid2mmctx() out of switch/case

Change-Id: I709f847802a975e1a75d0b87ac5125240cfd0854
---
M src/gprs/gprs_gmm.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/74/15174/1

diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index 6e5936c..ad02c4b 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1375,7 +1375,6 @@
 			ctx->gb.tlli = msgb_tlli(msg);
 			ctx->gb.llme = llme;
 		}
-		msgid2mmctx(ctx, msg);
 		break;
 	case GSM_MI_TYPE_TMSI:
 		memcpy(&tmsi, mi+1, 4);
@@ -1400,7 +1399,6 @@
 			ctx->gb.tlli = msgb_tlli(msg);
 			ctx->gb.llme = llme;
 		}
-		msgid2mmctx(ctx, msg);
 		break;
 	default:
 		LOGMMCTXP(LOGL_NOTICE, ctx, "Rejecting ATTACH REQUEST with "
@@ -1408,6 +1406,8 @@
 		reject_cause = GMM_CAUSE_MS_ID_NOT_DERIVED;
 		goto rejected;
 	}
+
+	msgid2mmctx(ctx, msg);
 	/* Update MM Context with currient RA and Cell ID */
 	ctx->ra = ra_id;
 	if (ctx->ran_type == MM_CTX_T_GERAN_Gb)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15174
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I709f847802a975e1a75d0b87ac5125240cfd0854
Gerrit-Change-Number: 15174
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/cf022d8e/attachment.html>


More information about the gerrit-log mailing list