Change in ...osmo-sgsn[master]: gprs_gmm.c: Improve doc on nullable parameters

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 13 09:54:01 UTC 2019


pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15160 )

Change subject: gprs_gmm.c: Improve doc on nullable parameters
......................................................................

gprs_gmm.c: Improve doc on nullable parameters

Change-Id: Iefb9b6dc34d87b4088c7535ef0a246103fe3f7e9
---
M src/gprs/gprs_gmm.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  lynxis lazus: Looks good to me, approved



diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index c93ddf4..f3ba290 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1959,7 +1959,7 @@
 	return 0;
 }
 
-/* GPRS Mobility Management */
+/* Rx GPRS Mobility Management. MMCTX can be NULL when called. On !Gb (Iu), llme is NULL  */
 static int gsm0408_rcv_gmm(struct sgsn_mm_ctx *mmctx, struct msgb *msg,
 			   struct gprs_llc_llme *llme, bool drop_cipherable)
 {
@@ -1967,7 +1967,6 @@
 	struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_gmmh(msg);
 	int rc;
 
-	/* MMCTX can be NULL when called */
 	if (drop_cipherable && gsm48_hdr_gmm_cipherable(gh)) {
 		LOGMMCTXP(LOGL_NOTICE, mmctx, "Dropping cleartext GMM %s which "
 			  "is expected to be encrypted for TLLI 0x%08x\n",

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15160
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iefb9b6dc34d87b4088c7535ef0a246103fe3f7e9
Gerrit-Change-Number: 15160
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/b635d9ad/attachment.html>


More information about the gerrit-log mailing list