Change in ...osmo-mgw[master]: tweak mgcp_parse_audio_ptime_rtpmap()

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 13 09:48:23 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15140 )

Change subject: tweak mgcp_parse_audio_ptime_rtpmap()
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/15140/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15140/1//COMMIT_MSG@12 
PS1, Line 12: - instead of strstr("rtpmap"), use osmo_str_startswith("a=rtpmap:") to more
> (There are no spaces at SDP line beginnings.) […]
What you say makes sense, but still not sure if the specs talks about whitespacing at the start of the line, so still something to have into account.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15140
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I730111e245da8485c1b5e8811f75d140e379cec6
Gerrit-Change-Number: 15140
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Aug 2019 09:48:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/b2d670bb/attachment.html>


More information about the gerrit-log mailing list