Change in ...osmo-mgw[master]: mgcp_codec: codec_set(): log about all possible errors

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 13 09:42:10 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15138 )

Change subject: mgcp_codec: codec_set(): log about all possible errors
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/15138/3/src/libosmo-mgcp/mgcp_codec.c 
File src/libosmo-mgcp/mgcp_codec.c:

https://gerrit.osmocom.org/#/c/15138/3/src/libosmo-mgcp/mgcp_codec.c@218 
PS3, Line 218: 		 * payload type number is unknown in this function??? */
you may find information with git blame? Or send an email to ML asking the author.

Without know much about this topic, reading comments below makes me thing it's in the case where dynamic payload type numbers are used to indicate well-known codecs which can be represented without dynamic payload numbers. BUt what I'm saying could be nonsense :)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15138
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I0b44b574c814882b6f8ae7cd738a6f481cd721fd
Gerrit-Change-Number: 15138
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Aug 2019 09:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/eaf5195b/attachment.html>


More information about the gerrit-log mailing list