This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgHello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/15132 to look at the new patch set (#2). Change subject: mgcp_codec: split codec_free() off of codec_init() ...................................................................... mgcp_codec: split codec_free() off of codec_init() Both are used only in the same .c file, so make them static. Move codec_set() guts into codec_add(): codec_set is only called by codec_add. If codec_set were left separate, it'd look like the codec_init() is a bug and lacks a codec_free() first. When looking at the entire context in codec_add(), it becomes obvious that codec_init() should be called, not codec_free(), because it is populating a previously unused entry. Preparation to fix a memleak in a conn's codec list. Change-Id: I120cab0a352a1e7b31c8f9c720c47b2c291311d7 --- M src/libosmo-mgcp/mgcp_codec.c 1 file changed, 35 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/32/15132/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I120cab0a352a1e7b31c8f9c720c47b2c291311d7 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190812/43ea797e/attachment.htm>