Change in ...libosmocore[master]: fsm: Quote received event token in logging line

fixeria gerrit-no-reply at lists.osmocom.org
Mon Aug 12 16:19:30 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15154 )

Change subject: fsm: Quote received event token in logging line
......................................................................


Patch Set 1: Code-Review+1

> It seems tons of unit tests in several projects depend on this line keeping same format... that's bad!

Yep, we definitely need some kind of "weak" matching in unit tests, like we do in the VTY tests.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15154
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibeaeb046058777c2367e3cbfff0e00fc7e3a1640
Gerrit-Change-Number: 15154
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Aug 2019 16:19:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190812/f1a9d59d/attachment.html>


More information about the gerrit-log mailing list