Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set

keith gerrit-no-reply at lists.osmocom.org
Mon Aug 12 11:55:11 UTC 2019


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 )

Change subject: avoid bogus error logs when no cmd_timer is set
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15142/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15142/1//COMMIT_MSG@9 
PS1, Line 9: mncc.c often calls stop_cmd_timer() even if no timer is running. If no timer is
I can't say I've seen this "often".

If we're calling stop_cmd_timer when there is no timer, should we rather not do that than hide the log message that we got a command we did not expect?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I70f85a71df55ab8618ed78864cefb6fe5b26f581
Gerrit-Change-Number: 15142
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-CC: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Mon, 12 Aug 2019 11:55:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190812/3c55a138/attachment.html>


More information about the gerrit-log mailing list