Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

keith gerrit-no-reply at lists.osmocom.org
Fri Aug 9 10:35:23 UTC 2019


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 )

Change subject: Implement a global switch on the network to disable call waiting.
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/gsm_04_08_cc.c 
File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/gsm_04_08_cc.c@1893 
PS10, Line 1893:  = NULL;
> explicit NULL assignment not needed, as you unconditionally set it to the return value of another fu […]
I wondered...s hould it just be one line then?

declare and assign at the same time:

struct gsm_trans *existing_cc_trans = trans_find_by_type(msc_a, TRANS_CC);



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae
Gerrit-Change-Number: 15120
Gerrit-PatchSet: 10
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Aug 2019 10:35:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at gnumonks.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190809/66d588fe/attachment.html>


More information about the gerrit-log mailing list