Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

laforge gerrit-no-reply at lists.osmocom.org
Fri Aug 9 08:17:44 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 )

Change subject: Implement a global switch on the network to disable call waiting.
......................................................................


Patch Set 10:

(2 comments)

https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/gsm_04_08_cc.c 
File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/gsm_04_08_cc.c@1893 
PS10, Line 1893:  = NULL;
explicit NULL assignment not needed, as you unconditionally set it to the return value of another function one line below.


https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/msc_vty.c 
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/msc_vty.c@296 
PS10, Line 296: callwaiting
I would suggest 'call-waiting' for better readability



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae
Gerrit-Change-Number: 15120
Gerrit-PatchSet: 10
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Aug 2019 08:17:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190809/50ddc7a1/attachment.html>


More information about the gerrit-log mailing list