This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15139 Change subject: explicitly free codecs in mgcp_rtp_conn_cleanup() ...................................................................... explicitly free codecs in mgcp_rtp_conn_cleanup() There are allocated bits in conn->end.codecs[], free them. This is not fixing a memleak, since mgcp_rtp_conn_cleanup() is currently only called from mgcp_conn_free(), which soon after frees the conn; the conn serves as talloc parent for the codec strings freed in this patch. The rationale: it is better style to explicitly free them, to also guard against future callers of mgcp_rtp_conn_cleanup() which might expect complete cleanup. Change-Id: Ic471107ce6e94d9ce582d887429c744ff93e3053 --- M src/libosmo-mgcp/mgcp_conn.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/39/15139/1 diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index 772584b..60a1700 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -129,6 +129,7 @@ conn_osmux_disable(conn_rtp); mgcp_free_rtp_port(&conn_rtp->end); rate_ctr_group_free(conn_rtp->rate_ctr_group); + mgcp_codec_reset_all(conn_rtp); } void mgcp_conn_watchdog_cb(void *data) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic471107ce6e94d9ce582d887429c744ff93e3053 Gerrit-Change-Number: 15139 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190809/0f889c50/attachment.htm>