Change in ...osmo-msc[master]: Fix dependency version requirements

neels gerrit-no-reply at lists.osmocom.org
Thu Aug 8 14:37:24 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15121 )

Change subject: Fix dependency version requirements
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/15121/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/15121/1//COMMIT_MSG@10 
PS1, Line 10: Fixes: 7c5346cd7005ad469702a2f74572b79de738fbbb
hmm, using the commit tag syntax is maybe not such a good idea? The "Fixes: " tag at the beginning of a line is often used to reference an open issue that gets fixed by this patch. I guess it would be better to omit the ':' to not confuse with that.

Also I'm not sure what you mean by "Fixes:" -- is this an osmo-msc commit hash? Maybe "introduced in ..."?


https://gerrit.osmocom.org/#/c/15121/1//COMMIT_MSG@24 
PS1, Line 24: 
also:

add missing version to libosmo-abis in debian/

fix libosmo-ranap version in debian/, out of sync with configure.ac



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15121
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1cd2c7317933b416b74a412f10e4cad16ecd6e59
Gerrit-Change-Number: 15121
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Aug 2019 14:37:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190808/13e21f81/attachment.html>


More information about the gerrit-log mailing list