Change in ...osmo-msc[master]: Implements a global switch on the network to disable call waiting.

keith gerrit-no-reply at lists.osmocom.org
Thu Aug 8 14:01:33 UTC 2019


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 )

Change subject: Implements a global switch on the network to disable call waiting.
......................................................................


Patch Set 1:

(1 comment)

> Build Failed
 > 
 > https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc/1824/ :
 > FAILURE

Aw boo. It built for me.

https://gerrit.osmocom.org/#/c/15120/1/src/libmsc/gsm_04_08_cc.c 
File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/#/c/15120/1/src/libmsc/gsm_04_08_cc.c@1806 
PS1, Line 1806: 	struct gsm_trans *_trans = NULL;
Not sure about this, but I got a segfault (in other code path) while testing, wasn't sure if it was due to my redefining trans below, so I left it here. As far as i can make out, if the code path continues, we are going to

 trans  = trans_alloc() 

anyway. but may be something I'm doing wring here with memory.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae
Gerrit-Change-Number: 15120
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Thu, 08 Aug 2019 14:01:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190808/10ff19a5/attachment.html>


More information about the gerrit-log mailing list